[DVDnav-discuss] misc issues
diego at biurrun.de
Sun Sep 14 23:32:12 CEST 2008
On Sun, Sep 14, 2008 at 10:06:19PM +0200, Nico Sabbi wrote:
> Il giorno dom, 14/09/2008 alle 21.50 +0200, Diego Biurrun ha scritto:
> > libdvdread and libdvdnav are full of
> > - $Id$
> > - $Log$
> I don't even know what they are good for, so ok to remove them for me
> > - missing license headers
> > I would like to remove/fix all of these. OK to proceed?
> > - extern "C"
> uhm, there are quite a few MSVC fanboys here, maybe better keep them
The 'extern "C"' declarations are only for C++, not directly related to
MSVC. But you are the boss, you get to decide either way. Not that I
think you could not get away with removing them ;-)
> > Also, it seems that you recently removed all trailing whitespace from
> > the code. Shall I enable the pre-commit hook to check for added
> > trailing whitespace?
> yes, please
More information about the DVDnav-discuss