[DVDnav-discuss] [PATCH]Missing function in Win32 pthreads

[Geoffroy Couprie]

On Sun, Sep 14, 2008 at 11:47 PM, Geoffroy Couprie <geal at videolan.org> wrote:
> On Sat, Sep 13, 2008 at 10:22 PM, Nico Sabbi <nicola.sabbi at poste.it> wrote:
>> Il giorno sab, 13/09/2008 alle 19.01 +0200, Geoffroy Couprie ha scritto:
>>> Hello,
>>>
>>> The pthread_mutex_destroy doesn't exist in the pthreads implementation
>>> for Windows. I don't know if it's the intended behaviour, but when
>>> leaving dvdnav, there's an attempt to free a block of memory where
>>> there is a critical section (apparently, it's bad :P). See the patch
>>> attached for a small fix.
>>
>> thanks, but I don't know anything about win32 programming.
>> I'll leave the decision to commit it or reject it to
>> someone more knowledgable
>>
> I think it won't do any harm. If there's a problem with it at runtime,
> that's because somewhere, you try to destroy a mutex already locked
> :).
> It won't change anything to the behaviour, that's just safer to
> destroy critical section when you don't use it anymore.
>


Well, thanks for having taken the time to review my patch. I hope it
will get applied one day, but I'm bored of waiting for it (that's not
a critical patch anyway).

Good luck with your future developments!

Geoffroy