[DVDnav-discuss] Re. [PATCH] Suppress error messages creating version.h from non-SVN checkout

[Dan Nicholson]

On Thu, May 1, 2008 at 2:14 AM, Nico Sabbi <Nicola.Sabbi at poste.it> wrote:
> >
>  >---------- Messaggio inoltrato ----------
>  >From: Dan Nicholson <dbn.lists at gmail.com>
>  >To: dvdnav-discuss at mplayerhq.hu
>  >Date: Mon, 28 Apr 2008 14:53:39 -0700
>  >Subject: [DVDnav-discuss] [PATCH] Suppress error messages creating version.h from non-SVN checkout
>  >---
>  > version.sh |    7 ++++---
>  > 1 files changed, 4 insertions(+), 3 deletions(-)
>  >
>  >diff --git a/version.sh b/version.sh
>  >index be67dcd..6ef2323 100755
>  >--- a/version.sh
>  >+++ b/version.sh
>  >@@ -1,8 +1,9 @@
>  > #!/bin/sh
>  >
>  >-svn_revision=`cd "$1" && LC_ALL=C svn info 2> /dev/null | grep Revision | cut -d' ' -f2`
>  >-test $svn_revision || svn_revision=`cd "$1" && grep revision .svn/entries | \
>  >-                                    cut -d '"' -f2 2> /dev/null`
>  >+svn_revision=`cd "$1" && LC_ALL=C svn info 2> /dev/null | \
>  >+    grep Revision 2> /dev/null | cut -d' ' -f2`
>
>  I don't see the point of this change (cosmetics apart)

Ah, you're right, the grep won't complain about empty input. I just
saw the bare grep and matched what I used for the second part.

--
Dan