[DVDnav-discuss] r1078 - trunk/libdvdread/autogen.sh

[Dan Nicholson]

On Sat, Jun 7, 2008 at 11:41 PM, Nico Sabbi <Nicola.Sabbi at poste.it> wrote:
> Il Saturday 07 June 2008 19:10:21 Dan Nicholson ha scritto:
>
>> Would you be opposed to adding pkgconfig files for libdvdread and
>> libdvdnav? It would make it much easier to find out how to build with
>> the libraries and to be able to specify which one to use.
>>
>
> I'm not opposed, but wouldn't they be a bit redundant now
> that we have dvdnav-config and dvdread-config ?

Oh, I missed the *-config scripts. That's good. However, the thing
about rolling your own config scripts is that it's tough get them to
do a couple things correctly:

1. Suppress -L and -I when they are in system directories. If you put
-L/usr/lib into your linking command, it overrides any earlier setting
of -L/usr/local/lib or any other non-standard directory.

2. Get them to behave correctly in a multiarch setting. This is often
because of 1, but there are other reasons.

pkg-config solves both of these problems (and a lot of others). I
almost guarantee that Fedora will roll their own pkg-config files for
these libraries and then patch the config scripts to behave "more
correctly":

http://cvs.fedoraproject.org/viewcvs/devel/esound/esound-multilib.patch?view=markup
http://cvs.fedoraproject.org/viewcvs/devel/gnutls/libgnutls-config?view=markup
http://cvs.fedoraproject.org/viewcvs/devel/SDL/SDL-1.2.12-multilib.patch?view=markup

Here's patches for dvdread and dvdnav to add support for pkg-config.
I'll understand if you don't want to apply them, but I think they're
worth having and require very little maintenance. The dvdnav patch
requires the fixes for dvdread through autotools patch I sent.

--
Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pkg-config-support-for-libdvdread.patch
Type: text/x-patch
Size: 3046 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080608/8e86c7eb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pkg-config-support-for-libdvdnav-and-libdvdnavmini.patch
Type: text/x-patch
Size: 3882 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080608/8e86c7eb/attachment-0001.bin>