[DVDnav-discuss] r1078 - trunk/libdvdread/autogen.sh

[Dan Nicholson]

On Sat, Jun 7, 2008 at 12:51 AM, Nico Sabbi <Nicola.Sabbi at poste.it> wrote:
> Il Friday 06 June 2008 22:58:33 Dan Nicholson ha scritto:
>> On Fri, Jun 6, 2008 at 1:53 PM, Nico Sabbi <Nicola.Sabbi at poste.it> wrote:
>> > Il Friday 06 June 2008 22:38:41 Dan Nicholson ha scritto:
>> >>
>> >> Nico, you can honestly drop all of this stuff. Just set
>> >> AC_PREREQ(version you want) before AC_INIT in configure.ac and
>> >> autoconf will fail if it doesn't meet the version.
>> >>
>> >> http://www.gnu.org/software/autoconf/manual/autoconf.html#index-AC_005fPREREQ-41
>> >
>> > good to know :) thanks
>>
>> In fact, most of autogen.sh can be killed. Here's the way to enforce
>> minimum automake version:
>>
>> http://www.gnu.org/software/automake/manual/automake.html#API-versioning
>>
>> And for libtool:
>>
>> http://www.gnu.org/software/libtool/manual/libtool.html#index-LT_005fPREREQ-85
>>
>> I'd also suggest just running autoreconf instead autoconf,
>> autoheader... manually. It's much smarter than we are about how to use
>> the autotools.
>>
>
> can you explain where I should insert LT_PREREQ([1.4]) ?
> autoreconf is fine but it doesn't seem to recognize this
> prerequisite.

It looks like it's only been added for libtool-2.2, so I guess you
need to keep checking the libtoolize version in autogen.sh.
Personally, I think you could do without it. libdvdnav is going to
build with libtool on any non-ancient host. libtool-1.4.0 is really
old now. Most projects don't enforce the libtool version, from what I
can tell. But it would be nice to use LT_PREREQ.

> BTW, IIRC you said that configure.ac can be considerably shrinked,
> thus I'd be grateful if you posted a patch :)

Yes. Attached are a couple patches for configure.ac and autogen.sh.
There attached. They only thing is that they don't handle the libtool
versioning thing above, so I don't know if you'll want to apply them
as is. There's certainly which could be done.

I have a patch for internal/external libdvdread, but it's difficult to
guess the include directory for dvdread since it appears to be moved.
Would you be opposed to adding pkgconfig files for libdvdread and
libdvdnav? It would make it much easier to find out how to build with
the libraries and to be able to specify which one to use.

--
Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Modernize-configure.ac-and-enforce-required-autotool.patch
Type: text/x-patch
Size: 3548 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080607/5fbbff5d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Drop-unnecessary-variables-set-in-configure.ac.patch
Type: text/x-patch
Size: 1685 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080607/5fbbff5d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Simplified-autogen.sh-wrapping-autoreconf-version-e.patch
Type: text/x-patch
Size: 8165 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20080607/5fbbff5d/attachment-0002.bin>