[DVDnav-discuss] [PATCH]es

Nico Sabbi Nicola.Sabbi at poste.it
Thu Jun 5 18:20:57 CEST 2008


On Thursday 05 June 2008 17:51:39 Rafaël Carré wrote:
> Le Thu, 5 Jun 2008 10:59:44 +0200,
>
> Nico Sabbi <Nicola.Sabbi at poste.it> a écrit :
> > > * add_missing_inttypes.diff
> > > src/dvdnav.h uses int32_t, so it needs its definition
> >
> > no good. I don't like to make headers include other headers
> > because these practice leads to bad coding. Include <inttypes.h>
> > in your .c file intead
>
> Every .c file which includes dvdnav.h will need inttypes.h anyway,
> so why not including it for them ?

for the reason I posted: it's not headers' responsability to 
include their dependencies. Headers just define their types and
functions, and IMO they should never work behind the back of the
including .c files



More information about the DVDnav-discuss mailing list