[DVDnav-discuss] [PATCH] pkgconfig support for libdvdread

[Dominik 'Rathann' Mierzejewski]

On Sunday, 13 July 2008 at 21:19, Dan Nicholson wrote:
> On Sun, Jul 13, 2008 at 02:39:18PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > Hi.
> > 
> > This adds pkgconfig .pc file generation to the build system.
> > 
> > Patch attached. OK to apply? Dan, could you add the corresponding autotools
> > part?
> 
> Shoot. I'd done this about a month ago, but never committed it. Dominik,
> one thing that would make the autotools much easier would be to have a
> .pc.in file that we can substitute values in with sed. Then it can just
> be another output from configure. Below is what I did before. Do you
> think we can handle them this way?

Yes, I guess we should. Unfortunately I've already committed my patches
so there's a conflict now... I guess I'll revert mine and work with yours
instead.

> --- /dev/null
> +++ b/misc/libdvdnav.pc.in
> @@ -0,0 +1,12 @@
> +prefix=@prefix@
> +exec_prefix=@exec_prefix@
> +libdir=@libdir@
> +includedir=@includedir@
> +
> +Name: libdvdnav
> +Description: DVD Navigation library
> +Version: @VERSION@
> +
> +Requires: dvdread

This needs to be Requires.private. libdvdnav doesn't expose any libdvdread symbols
to the public.

Looks fine otherwise.

Regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"