[DVDnav-discuss] [PATCH] clean up header mess

Nico Sabbi nicola.sabbi at poste.it
Tue Dec 30 15:01:51 CET 2008


Il giorno mar, 30/12/2008 alle 14.41 +0100, Reimar Döffinger ha scritto:
> On Tue, Dec 30, 2008 at 02:21:22PM +0100, Reimar Döffinger wrote:
> > I think the way headers are currently are a mess, it needs that ugly
> > -DDVDNAV_COMPILE and it makes it impossible to use dvdnav directly from
> > the directory where it was compiled without installing (which is also a
> > useful feature for directly integrating dvdnav into a project like it is
> > done for dvdread in MPlayer).
> > The patch looks a bit ugly, but the most it does is moving the dvdnav.h,
> > dvd_types.h and dvdnav_events.h headers into a dvdnav subdirectory (if
> > only svn diff could display file moves in a readable way!),
> > adjusts the paths in the includes and makes dvdnav.h always include
> > dvd_types.h and dvdnav_events.h which means quite a few #includes can be
> > removed.
> > If this looks ok, I'd like to do the same with dvdread and hopefully
> > soon replacing the MPlayer copy with an svn external somewhen...
> 
> For better readability and because the other mail got stuck in
> moderation due to size, here the patch with the parts removed that
> show the three moved headers being removed from src/.
> 

ok to commit anytime. Thanks




More information about the DVDnav-discuss mailing list