[DVDnav-discuss] [PATCH] restore old-upstream-compatible API (was Re: current revision strangeness)

[Dominik 'Rathann' Mierzejewski]

On Wednesday, 20 August 2008 at 21:03, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 20 August 2008 at 20:00, Nico Sabbi wrote:
[...]
> > sorry, I missed or forgotten your post. Do you want to rename
> > libdvdread as dvdread?
> 
> Rename the include path from libdvdread/*.h back to dvdread/*.h, yes.
> Note that libdvdnav similarly has dvdnav/*.h for public headers.
> 
> > why? dvdread is a LIBrary, I don't see why it shouldn't be called
> > libdvdread.
> 
> I'm not suggesting renaming the library itself.
> 
> > It's also another way to distinguish it from the old code.
> 
> Why do you want to distinguish it from the old code? It's a fork,
> granted, but it's the only actively developed fork, which makes
> it upstream.
> 
> > Or did I misunderstand what you mean?
> 
> Apparently, at least partially. So, do you agree to put the include
> path back to dvdread/*.h?

And here's the patch. If there are no objections, I'm going to apply
this on Monday.

Regards,
R.

-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"
-------------- next part --------------
Index: src/Makefile.am
===================================================================
--- src/Makefile.am	(revision 1120)
+++ src/Makefile.am	(working copy)
@@ -1,6 +1,6 @@
 include $(top_srcdir)/misc/Makefile.common
 
-includedir = ${prefix}/include/libdvdread
+includedir = ${prefix}/include/dvdread
 
 AM_CPPFLAGS = -I$(top_srcdir)/src
 
Index: configure2
===================================================================
--- configure2	(revision 1120)
+++ configure2	(working copy)
@@ -96,7 +96,7 @@
 
 test -z "$libdir" && libdir=$PREFIX/lib
 test -z "$shlibdir" && shlibdir=$PREFIX/lib
-test -z "$incdir" && dvdread_incdir=$PREFIX/include/libdvdread
+test -z "$incdir" && dvdread_incdir=$PREFIX/include/dvdread
 
 targetos=`uname -s`
 case $targetos in