[DVDnav-discuss] r1014 - trunk/libdvdnav/ChangeLog

[Erik Hovland]

On Sat, Apr 19, 2008 at 09:51:12PM +0200, Nico Sabbi wrote:
> Il Saturday 19 April 2008 21:53:40 nicodvb ha scritto:
> 
> > 
> > Modified: trunk/libdvdnav/ChangeLog
> > ==============================================================================
> > --- trunk/libdvdnav/ChangeLog	(original)
> > +++ trunk/libdvdnav/ChangeLog	Sat Apr 19 21:53:40 2008
> > @@ -1,3 +1,6 @@
> > +libdvdnav /4.1.3)
> > +  * an embarassing amount of fixes regarding potential memory and resource leaks
> > +    (patches contributed by Erik Hovland)
> 
> the right name for dvdread is dvdsieve ;(

I would not be so hard on dvdnav. According to the static analysis
checker there are about 24000 lines of code and it found about 24
defects. Of which only 19 are valid (if you think dlclose should not be
called on successful return). That means that there were less then 1
defect per one thousand lines. My experience with free software is that
is above average.

The source in MythTV is actually older (and has more defects per
thousand lines). So your tree is in much better shape.

The single worst piece of old code that you have obviously fixed was
src/searching.c. So you devs were already squashing bugs before that
static analysis checker came along.

E

-- 
Erik Hovland
mail: erik at hovland.org
web: http://hovland.org/
PGP/GPG public key available on request