[DVDnav-discuss] [PATCH] bugfix for compile minilib of libdvdnav

[Ulion]

2007/9/19, Ulion <ulion2002 at gmail.com>:
> 2007/9/19, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> > Ulion wrote:
> > > Hello,
> > >
> > > I also encounter a problem with the '-e' option of echo when generate
> > > dvdnav-config file, '-e' was printed into the targetfile also. I'm
> > > under ubuntu 7.04 on a PowerPC 64 just installed. Test echo command
> > > result just ok but when call it in the Makefile, it seems already has
> > > a '-e' hiddenly,  maybe there's some alias somewhere. To fix it, I use
> > > a absolate path to call echo:
> > >
> > > Index: libdvdnav/Makefile
> > > ===================================================================
> > > --- libdvdnav/Makefile  (revision 955)
> > > +++ libdvdnav/Makefile  (working copy)
> > > @@ -127,11 +127,11 @@
> > >         rm -rf config.mak
> > >
> > >  dvdnav-config: $(.OBJDIR)
> > > -       echo -e '#!/bin/sh\n\nprefix='$(PREFIX)'\n' > $(.OBJDIR)/dvdnav-config
> > > -       echo -e 'version='$(SHLIB_VERSION)'\n' >> $(.OBJDIR)/dvdnav-config
> > > -       echo -e 'dvdread='$(DVDREAD)'\n' >> $(.OBJDIR)/dvdnav-config
> > > -       echo -e 'dvdreaddir='$(DVDREAD_DIR)'\n' >> $(.OBJDIR)/dvdnav-config
> > > -       echo -e 'threadlib='$(THREADLIB)'\n\n' >> $(.OBJDIR)/dvdnav-config
> > > +       /bin/echo -e '#!/bin/sh\n\nprefix='$(PREFIX)'\n' >
> > > $(.OBJDIR)/dvdnav-config
> > > +       /bin/echo -e 'version='$(SHLIB_VERSION)'\n' >> $(.OBJDIR)/dvdnav-config
> > > +       /bin/echo -e 'dvdread='$(DVDREAD)'\n' >> $(.OBJDIR)/dvdnav-config
> > > +       /bin/echo -e 'dvdreaddir='$(DVDREAD_DIR)'\n' >> $(.OBJDIR)/dvdnav-config
> > > +       /bin/echo -e 'threadlib='$(THREADLIB)'\n\n' >> $(.OBJDIR)/dvdnav-config
> > >         cat $(SRC_PATH_BARE)/misc/dvdnav-config2.sh >> $(.OBJDIR)/dvdnav-config
> > >         chmod 0755 $(SRC_PATH_BARE)/$(.OBJDIR)/dvdnav-config
> > >
> > >
> >
> > something is broken in your setup. I can't commit such workarounds
>
> I understand. use '/bin/echo' may break on other platform, so just
> post here to let peoples known how to fix it if they encounter the
> same problem.
>

After check other Makefiles, I found they all use '@echo' instead of
'echo -e', I tested with it and works just like '/bin/echo -e', maybe
'@echo' is the correct way to use. So I think this patch will be worth
to commit. I made this patch under libdvdnav directory, so need apply
it under same directory.

-- 
Ulion
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libdvdnav_makefile_echofix.diff
Type: text/x-diff
Size: 1143 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20071124/2c012dd5/attachment.diff>