[DVDnav-discuss] r964 - in trunk/libdvdnav: Makefile misc/dvdnav-config2.sh

[Diego 'Flameeyes' Pettenò]

nicodvb <subversion at mplayerhq.hu> writes:

> +	cd $(.OBJDIR) && $(CC) $(SHLDFLAGS) -ldvdread $(THREADLIB) -o $@ $(SHOBJS)

This will fail badly when you use -Wl,--as-needed (and many people do
use this by default nowadays, distributions too).

The order of parameters in a linking command should be:

$LD $LDFLAGS $OBJECTS $LIBS

-o is an LD flag so you would put it before the objects, but for easy
reading, putting it at the end is not a problem.

Of course $LD could be $(CC) or $(CXX) depending on the language used.

-- 
Diego "Flameeyes" Pettenò
http://farragut.flameeyes.is-a-geek.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20071117/58c130b9/attachment.pgp>