[DVDnav-discuss] packaging libdvdnav and libdvdread and [PATCH]

[Nico Sabbi]

Dominik 'Rathann' Mierzejewski wrote:
> On Sunday, 19 August 2007 at 18:29, Nico Sabbi wrote:
> 
>>Dominik 'Rathann' Mierzejewski wrote:
>>
>>>Hi.
>>>
>>>As some of you might know, I'm responsible for creating RPM packages of
>>>some of our software, for example FFmpeg and MPlayer. Some time ago I took
>>>over packaging libdvdread and libdvdnav, too. I've already switched to this
>>>fork for dvdnav and seeing how things are, I'm preparing to switch to this
>>>dvdread as well, when it's forked.
>>
>>it's already forked
> 
> 
> Well, src/dvdread is quite different from upstream dvdread. For example,
> it's missing cmd_print.[c|h] and the diff is 180K in size even if you don't
> count the missing files.

indeed, but those files (like ifo_print.c) are needed only to dump the 
content of the metadata, not to actually play dvds. In any case patch 
welcome

> 
> 
>>> Which dvdnav version should I use, libdvdnav or libdvdnav2? 
>>
>>libdvdnav
> 
> 
> But this one has internal dvdread, right?


the internal dvdread that has been recently promoted  by me :)

>>
>>>One more thing: it's been brought to my attention that compiling C++ code
>>>that uses dvdnav.h header fails, because "this" is a reserved word in C++.
>>>Patch attached.
> 
> [...]
> 
>>patch ok
> 
> 
> Applied to both trunks.
> 

thanks