[DVDnav-discuss] whoops, mplayer configure doesn't like dvdnav r897 right now ; )

[Nico Sabbi]

sci-fi at hush.ai wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> Hi again,
> 
> Ah-oh, we're missing something in your new dvdnav's headers at
> svn r897.
> 
> I ran its original configure script since configure2 still has
> problems as we're discussing in another thread here.
> 
> My ffmpeg/mplayer copies are at r8781/r23064.
> 
> After installing dvdnav r897, I let mplayer configure
> auto-detect which dvd support to decide to use on its own, and
> now at r897 it is having a problem here in its config.log:
> 
> ##########################################
> 
> Result is: no
> ##########################################

should be fixed. svn update mplayer and dvdnav

> 
> Before you moved the #includes around, mplayer configure was
> working properly in this area.
> 
> ATPT directly underneath this part of config.log, it will decide
> to use external dvdread (built myself from that project).
> Mplayer then has further build problems from that point on, but
> that's o.t. for this list.
> 
> Please realise the massive gcc options are to get around Apple's
> - -fast switch, the ones shown above are the equivalents without
> the buggy ones that we're able to determine ATPT.  I actually
> have successfully built your new dvdnav this way at a previous
> svn rev _before_ you moved the #includes around.  ;)  (we'll get
> to whether dvdnav really works on osx later when everything's
> settled...)
> 
> I know you might not be thru with re-adjusting everything.
> No biggee, just trying to help before it gets worse.  ;)
> 

the old inclusion system was a disaster, worth  destroying.
There's still a massive set of includes in dvdnav.h and
especially dvdnav_internal.h that sooner or later I'll clean.
Headers should never include other headers, or you will get a huge
mess