[DVDnav-discuss] [PATCH] [?] Don't check for memcpy() presence, assume it's available

Diego 'Flameeyes' Pettenò flameeyes at gmail.com
Tue Apr 17 19:55:28 CEST 2007


I can't think of any case off the top of my head where memcpy()
function is not available, and bcopy has to be used instead, but the
md5.c source file (from dvdread) seems to be taken out of glibc, and it
checks for HAVE_MEMCPY before using it, otherwise uses bcopy.

With this patch (that I'm not sure if it's okay to apply as it changes
dvdread sources), memcpy check is skipped, and it's always used instead.

This also removes the implicit declarations warnings (that become errors
when compiled with xine).

Note that luckily the return value of memcpy() is never used in md5.c
so there's no risk that a broken pointer is dereferenced with the
implicit declarations.

-- 
Diego "Flameeyes" Pettenò
http://farragut.flameeyes.is-a-geek.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libdvdnav-dvdread-md5-memcpy.patch
Type: text/x-patch
Size: 482 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20070417/cf6ef408/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/dvdnav-discuss/attachments/20070417/cf6ef408/attachment.pgp>


More information about the DVDnav-discuss mailing list